Bug fix for wgrib2 from release/1.9.0: support variant netcdf when=@3.6: (#561)#568
Conversation
|
@AlysonStahl-NOAA can you give this a quick look? |
Just note that this bug fix can be a hack; after this PR, the spack submodule will be frozen until the update from the spack v1 branches is merged. With that merge, the spack code will no longer contain the builtin repo. Rather, the correct bug fix needs to go into the new spack-packages repository (upstream or the JCSDA fork). |
|
The options to use netcdf3 or netcdf4 merged into a single option with v3.4.0, so I believe this fix should be implemented for 3.4.0+. |
|
@AlexanderRichert-NOAA @rickgrubin-noaa Is this version ok? |
Perhaps add the comment
if desired; but yes, OK. |
rickgrubin-noaa
left a comment
rickgrubin-noaa
left a comment
There was a problem hiding this comment.
As noted in the PR conversation, perhaps add the comment
# options to use netcdf3 or netcdf4 merged into a single option with v3.4.0
4 participants
Description
Cherry-picking 30eb08b from
release/1.9.0for develop to fix the CI build errors discussed in JCSDA/spack-stack#1790 (comment). This is the same as PR #561 that went intorelease/1.9.0, but updated to match the correct wgrib2 versions that need the fix (see discussion below).Because the JCSDA spack-stack-dev branch will have all of the packages removed as part of the move to spack v1 (spack-stack v2), this is going to be the last PR for the packages inside the old spack v0.23 code.
Testing
See JCSDA/spack-stack#1790